Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: simplify the limit judgment of hot-region-scheduler (#3834) #3854

Merged
merged 1 commit into from
Jul 16, 2021
Merged

scheduler: simplify the limit judgment of hot-region-scheduler (#3834) #3854

merged 1 commit into from
Jul 16, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3834

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

related #3778
changes caused by #3820

What is changed and how it works?

OpLeader and LeaderScheduleLimit are no longer judged in balance-hot-region-scheduler.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jul 9, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 9, 2021
Merged
@ti-chi-bot ti-chi-bot added component/scheduler Scheduler logic. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. labels Jul 9, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Jul 9, 2021

The pre-PR is #3858

@zhouqiang-cl zhouqiang-cl added backport-4.0.14 cherry-pick-approved Cherry pick PR approved by release team. labels Jul 14, 2021
@nolouch
Copy link
Contributor

nolouch commented Jul 15, 2021

@HunDunDM #3858 already merged.

@HunDunDM
This is an automated cherry-pick of tikv#3834
fba249d 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM force-pushed the cherry-pick-3834-to-release-4.0 branch from e194253 to fba249d Compare July 16, 2021 02:39
@HunDunDM HunDunDM added this to the v4.0.14 milestone Jul 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #3854 (fba249d) into release-4.0 (11497a4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3854      +/-   ##
===============================================
- Coverage        74.70%   74.69%   -0.01%     
===============================================
  Files              211      211              
  Lines            19993    19978      -15     
===============================================
- Hits             14936    14923      -13     
+ Misses            3722     3718       -4     
- Partials          1335     1337       +2
Flag Coverage Δ
unittests 74.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 79.96% <0.00%> (-1.07%) ⬇️
pkg/etcdutil/etcdutil.go 72.05% <0.00%> (-10.30%) ⬇️
server/id/id.go 76.19% <0.00%> (-9.53%) ⬇️
server/kv/etcd_kv.go 78.26% <0.00%> (-7.25%) ⬇️
pkg/mock/mockhbstream/mockhbstream.go 87.03% <0.00%> (-1.86%) ⬇️
server/member/leader.go 63.76% <0.00%> (-1.38%) ⬇️
server/grpc_service.go 58.66% <0.00%> (-1.21%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
server/server.go 73.94% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11497a4...fba249d. Read the comment docs.

nolouch
nolouch approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 16, 2021
@nolouch
Copy link
Contributor

nolouch commented Jul 16, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: fba249d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021
@ti-chi-bot ti-chi-bot merged commit 72d5b7c into tikv:release-4.0 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch nolouch approved these changes

@disksing disksing Awaiting requested review from disksing

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@HunDunDM HunDunDM

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Milestone
v4.0.14
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @HunDunDM @nolouch @lhy1024 @zhouqiang-cl